Github user tony810430 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5115#discussion_r154655734
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/AbstractMetricGroup.java
---
@@ -409,6 +404,22 @@ public MetricGroup addGroup(String name) {
return addGroup(name, false);
}
+ @Override
+ public MetricGroup addGroup(String key, String value) {
--- End diff --
This change wants to make the fallback behavior more reasonable.
When user uses this method, he will want the key be a key and the value be
a value.
But in the previous approach, if the parent group is key group, that will
leads to key becomes to value and value becomes the new key.
I think it is more acceptable to make these unexpected behavior fall back
to ordinary metric group.
What do you think?
---
