Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5115#discussion_r154946902
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/AbstractMetricGroup.java
---
@@ -416,10 +441,14 @@ public MetricGroup addGroup(String name) {
}
else {
// return a non-registered group that is
immediately closed already
- GenericMetricGroup closedGroup = new
GenericMetricGroup(registry, this, name);
+ GenericMetricGroup closedGroup =
createChildGroup(name);
closedGroup.close();
return closedGroup;
}
}
}
+
+ protected GenericMetricGroup createChildGroup(String name) {
--- End diff --
let's rename this to `createChildGroupInKeyedContext`
---
