Github user tony810430 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5115#discussion_r154936137
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/AbstractMetricGroup.java
---
@@ -409,6 +404,22 @@ public MetricGroup addGroup(String name) {
return addGroup(name, false);
}
+ @Override
+ public MetricGroup addGroup(String key, String value) {
--- End diff --
The reasont why I reverted the previous implementation is that I want to
make `MetricGroup#addGroup(String name)` always create `GenericMetricGroup`,
even through the class type of `group` is `GenericKeyMericGroup`.
---
