[GitHub] flink pull request #5115: [FLINK-7692] [metrics] Support user-defined variab...

[zentol]

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5115#discussion_r154665095
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/AbstractMetricGroup.java
 ---
    @@ -409,6 +404,22 @@ public MetricGroup addGroup(String name) {
                return addGroup(name, false);
        }
     
    +   @Override
    +   public MetricGroup addGroup(String key, String value) {
    --- End diff --
    
    Wouldn't it be cleaner to override `addGroup(String key, String value)` in 
`GenericKeyMetricGroup` instead?


---