Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/5105#discussion_r156425243
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/api/writer/RecordWriterTest.java
---
@@ -118,7 +122,7 @@ public Buffer answer(InvocationOnMock invocation)
throws Throwable {
};
BufferProvider bufferProvider =
mock(BufferProvider.class);
-
when(bufferProvider.requestBufferBlocking()).thenAnswer(request);
+
when(bufferProvider.requestBufferBuilderBlocking()).thenAnswer(request);
--- End diff --
Wouldn't it be enough to have a `TestPooledBufferProvider` with an
appropriate recycler and just one buffer to create the same behaviour but
without a mock?
---
