Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/5105#discussion_r156421194
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPool.java
---
@@ -179,7 +179,8 @@ public void setBufferPoolOwner(BufferPoolOwner owner) {
@Override
public Buffer requestBuffer() throws IOException {
try {
- return requestBuffer(false);
+ BufferBuilder bufferBuilder =
requestBufferBuilder(false);
+ return bufferBuilder != null ? bufferBuilder.build() :
null;
--- End diff --
Actually, the remaining non-test call in `PartitionRequestClientHandler`
could also use the `BufferBuilder`. Then, you could remove this method after
adapting the tests.
---
