Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/5105#discussion_r156386302
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/SpilledSubpartitionViewTest.java
---
@@ -48,8 +47,7 @@
private static final IOManager IO_MANAGER = new IOManagerAsync();
- private static final TestInfiniteBufferProvider writerBufferPool =
- new TestInfiniteBufferProvider();
+ private static final TestPooledBufferProvider writerBufferPool = new
TestPooledBufferProvider(Integer.MAX_VALUE);
--- End diff --
From what I see, `TestPooledBufferProvider` keeps a queue of created
buffers which is never cleaned up. If we use this in the heap (as in the
`RecordWriterTest`), we should be fine since no remaining reference to the
object will gc it. However, imho, this static member cannot be gc'd and we
should at least offer some `destroy()` method and call it once done with the
test.
---
