Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/5105#discussion_r156411078
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/serialization/SpanningRecordSerializer.java
---
@@ -50,24 +51,15 @@
private final ByteBuffer lengthBuffer;
/** Current target {@link Buffer} of the serializer */
- private Buffer targetBuffer;
-
- /** Current {@link MemorySegment} of target buffer */
- private MemorySegment targetMemorySegment;
-
- /** Position in current {@link MemorySegment} of target buffer */
- private int position;
-
- /** Limit of current {@link MemorySegment} of target buffer */
- private int limit;
+ private BufferBuilder targetBuffer;
--- End diff --
should we mark this `@Nullable`?
---
