Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/5200#discussion_r160107827
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java
---
@@ -770,8 +777,8 @@ public final void notifyCheckpointComplete(long
checkpointId) throws Exception {
return;
}
- final AbstractFetcher<?, ?> fetcher = this.kafkaFetcher;
- if (fetcher == null) {
+ final KafkaOffsetCommitter offsetCommitter =
this.kafkaOffsetCommitter;
--- End diff --
why do we need this `final` local variable? `kafkaOffsetCommitter` seems to
be "write-once" variable.
---
