Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/5200#discussion_r160105955
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/AbstractFetcher.java
---
@@ -51,7 +50,7 @@
* the Flink data streams.
* @param <KPH> The type of topic/partition identifier used by Kafka in
the specific version.
*/
-public abstract class AbstractFetcher<T, KPH> {
+public abstract class AbstractFetcher<T, KPH> implements
KafkaOffsetCommitter {
--- End diff --
Maybe use composition instead of inheritance here? `AbstractFetcher` as
"being a" `KafkaOffsetCommitter` do not make sense to me when I say it out
laud, while `AbstractFetcher` "having a" `KafkaOffsetCommitter` sounds better.
---
