[GitHub] flink pull request #5200: [FLINK-8306] [kafka] Introduce KafkaOffsetCommitte...

[pnowojski]

Github user pnowojski commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5200#discussion_r160103116
  
    --- Diff: 
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java
 ---
    @@ -887,4 +894,9 @@ OffsetCommitMode getOffsetCommitMode() {
        LinkedMap getPendingOffsetsToCommit() {
                return pendingOffsetsToCommit;
        }
    +
    +   @VisibleForTesting
    +   KafkaOffsetCommitter createOffsetCommitter() {
    --- End diff --
    
    rename to `getOffsetCommitter()`?


---