Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/4587#discussion_r162044383
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/pattern/AndFilterFunction.java
---
@@ -1,55 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package org.apache.flink.cep.pattern;
-
-import org.apache.flink.api.common.functions.FilterFunction;
-
-/**
- * A filter function which combines two filter functions with a logical
and. Thus, the filter
- * function only returns true, iff both filters return true.
- *
- * @param <T> Type of the element to filter
- * @deprecated This is only used when migrating from an older Flink
version.
- * Use the {@link org.apache.flink.cep.pattern.conditions.AndCondition}
instead.
- */
-@Deprecated
-public class AndFilterFunction<T> implements FilterFunction<T> {
--- End diff --
Sorry for the late response.
Actually not sure about the value of testing those conditions explicitly.
In fact it would just test if they are serializable. Anyway they are not
intended for explicit usage (they could be annotated with `@Internal`, but it
should be done as a separate task IMHO). Plus subtype is covered in migration
tests (the `subtype` function on pattern).
---
