[ 
https://issues.apache.org/jira/browse/FLINK-8626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16358509#comment-16358509
 ] 

ASF GitHub Bot commented on FLINK-8626:
---------------------------------------

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/5443

    [FLINK-8626] Introduce BackPressureStatsTracker interface

    ## What is the purpose of the change
    
    Renames BackPressureStatsTracker into BackPressureStatsTrackerImpl and 
introduce
    a BackPressureStatsTracker interface. This will make testing easier when we 
don't
    have to set up all the different components.
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink 
introduceBackPressureStatsTrackerInterface

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5443.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5443
    
----
commit 8e172aee75e9e0c81608ed7e6796bca1ea7d7544
Author: Till Rohrmann <trohrmann@...>
Date:   2018-02-09T13:07:31Z

    [FLINK-8626] Introduce BackPressureStatsTracker interface
    
    Renames BackPressureStatsTracker into BackPressureStatsTrackerImpl and 
introduce
    a BackPressureStatsTracker interface. This will make testing easier when we 
don't
    have to set up all the different components.

----


> Introduce BackPressureStatsTracker interface
> --------------------------------------------
>
>                 Key: FLINK-8626
>                 URL: https://issues.apache.org/jira/browse/FLINK-8626
>             Project: Flink
>          Issue Type: Improvement
>          Components: REST, Tests
>    Affects Versions: 1.5.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Minor
>             Fix For: 1.5.0
>
>
> In order to better test components like the {{JobMaster}} we should introduce 
> a {{BackPressureStatsTracker}} interface and rename the current 
> {{BackPressureStatsTracker}} class into {{BackPressureStatsTrackerImpl}}. 
> This will simplify testing where we have to set up all these things.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to