[
https://issues.apache.org/jira/browse/FLINK-8626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16359658#comment-16359658
]
ASF GitHub Bot commented on FLINK-8626:
---------------------------------------
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5443#discussion_r167412925
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/rest/handler/legacy/JobVertexBackPressureHandlerTest.java
---
@@ -57,7 +57,7 @@ public void testGetPaths() {
@Test
public void testResponseNoStatsAvailable() throws Exception {
ExecutionJobVertex jobVertex = mock(ExecutionJobVertex.class);
- BackPressureStatsTracker statsTracker =
mock(BackPressureStatsTracker.class);
+ BackPressureStatsTrackerImpl statsTracker =
mock(BackPressureStatsTrackerImpl.class);
--- End diff --
we could replace the mocks in this class with VoidBackPressureStatsTracker
/ lambda implementations.
> Introduce BackPressureStatsTracker interface
> --------------------------------------------
>
> Key: FLINK-8626
> URL: https://issues.apache.org/jira/browse/FLINK-8626
> Project: Flink
> Issue Type: Improvement
> Components: REST, Tests
> Affects Versions: 1.5.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Priority: Minor
> Fix For: 1.5.0
>
>
> In order to better test components like the {{JobMaster}} we should introduce
> a {{BackPressureStatsTracker}} interface and rename the current
> {{BackPressureStatsTracker}} class into {{BackPressureStatsTrackerImpl}}.
> This will simplify testing where we have to set up all these things.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
