[ 
https://issues.apache.org/jira/browse/FLINK-8626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16358589#comment-16358589
 ] 

ASF GitHub Bot commented on FLINK-8626:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5443#discussion_r167268048
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/backpressure/VoidBackPressureStatsTracker.java
 ---
    @@ -0,0 +1,36 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.runtime.rest.handler.legacy.backpressure;
    +
    +import org.apache.flink.runtime.executiongraph.ExecutionJobVertex;
    +
    +import java.util.Optional;
    +
    +/**
    + * {@link BackPressureStatsTracker} implementation which returns always no 
back pressure statistics.
    --- End diff --
    
    switch "returns" and "always"?


> Introduce BackPressureStatsTracker interface
> --------------------------------------------
>
>                 Key: FLINK-8626
>                 URL: https://issues.apache.org/jira/browse/FLINK-8626
>             Project: Flink
>          Issue Type: Improvement
>          Components: REST, Tests
>    Affects Versions: 1.5.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Minor
>             Fix For: 1.5.0
>
>
> In order to better test components like the {{JobMaster}} we should introduce 
> a {{BackPressureStatsTracker}} interface and rename the current 
> {{BackPressureStatsTracker}} class into {{BackPressureStatsTrackerImpl}}. 
> This will simplify testing where we have to set up all these things.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to