[ 
https://issues.apache.org/jira/browse/FLINK-8626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16359655#comment-16359655
 ] 

ASF GitHub Bot commented on FLINK-8626:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5443#discussion_r167412844
  
    --- Diff: 
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/WebRuntimeMonitor.java
 ---
    @@ -143,7 +143,7 @@
     
        private final StackTraceSampleCoordinator stackTraceSamples;
     
    -   private final BackPressureStatsTracker backPressureStatsTracker;
    +   private final BackPressureStatsTrackerImpl backPressureStatsTrackerImpl;
    --- End diff --
    
    Actually not, because the legacy `JobVertexBackPressureHandler` needs to 
call methods of the implementation which are not part of the interface.


> Introduce BackPressureStatsTracker interface
> --------------------------------------------
>
>                 Key: FLINK-8626
>                 URL: https://issues.apache.org/jira/browse/FLINK-8626
>             Project: Flink
>          Issue Type: Improvement
>          Components: REST, Tests
>    Affects Versions: 1.5.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Minor
>             Fix For: 1.5.0
>
>
> In order to better test components like the {{JobMaster}} we should introduce 
> a {{BackPressureStatsTracker}} interface and rename the current 
> {{BackPressureStatsTracker}} class into {{BackPressureStatsTrackerImpl}}. 
> This will simplify testing where we have to set up all these things.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to