Github user NicoK commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5572#discussion_r170562983
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartition.java
 ---
    @@ -208,7 +208,7 @@ public ResultSubpartitionView 
createReadView(BufferAvailabilityListener availabi
                                        
parent.getBufferProvider().getMemorySegmentSize(),
                                        availabilityListener);
                        }
    -
    +                   readView.notifyDataAvailable();
    --- End diff --
    
    I know that both read views` implementation of this function are no-ops, 
but both constructors do their own notification handling already, so this 
should probably be removed again


---

Reply via email to