Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/5572#discussion_r170589453
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartitionTest.java
---
@@ -319,7 +319,7 @@ public void
testConsumeSpillablePartitionSpilledDuringConsume() throws Exception
assertEquals(2, partition.getBuffersInBacklog());
assertEquals(partition.getBuffersInBacklog(),
read.buffersInBacklog());
read.buffer().recycleBuffer();
- assertEquals(2, listener.getNumNotifications());
+ assertEquals(1, listener.getNumNotifications());
--- End diff --
maybe add a small comment that we don't get a new notification (anymore!)
since the buffer is already available at the `getNextBuffer()` call?
---
