Github user NicoK commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5572#discussion_r170573898
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartitionView.java
 ---
    @@ -187,7 +185,6 @@ public BufferAndBacklog getNextBuffer() throws 
IOException, InterruptedException
     
        @Override
        public void notifyDataAvailable() {
    -           // We do the availability listener notification one by one
    --- End diff --
    
    Well, this is still true for the `SpilledSubpartitionView` and without the 
(potentially extended) comment here, a reader might wonder why we don't do 
anything here, not even forwarding it to the spilled view.


---

Reply via email to