[GitHub] flink pull request #5572: [FLINK-8694][runtime] Fix notifyDataAvailable race...

[NicoK]

Github user NicoK commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5572#discussion_r170560833
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
 ---
    @@ -65,9 +67,8 @@ public boolean add(BufferConsumer bufferConsumer) {
        @Override
        public void flush() {
                synchronized (buffers) {
    -                   if (readView != null) {
    -                           readView.notifyDataAvailable();
    -                   }
    +                   flushRequested = !buffers.isEmpty();
    +                   notifyDataAvailable();
    --- End diff --
    
    maybe don't even flush at all if buffers is empty


---