[GitHub] flink pull request #5572: [FLINK-8694][runtime] Fix notifyDataAvailable race...

[NicoK]

Github user NicoK commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5572#discussion_r170631511
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/SpilledSubpartitionView.java
 ---
    @@ -219,6 +219,14 @@ public boolean nextBufferIsEvent() {
                }
        }
     
    +   @Override
    +   public synchronized boolean isAvailable() {
    +           if (nextBuffer != null) {
    +                   return true;
    +           }
    +           return fileReader.hasReachedEndOfFile();
    --- End diff --
    
    should be `!fileReader.hasReachedEndOfFile();` - I will add tests in a 
later PR for this


---