[jira] [Commented] (FLINK-8686) Improve basic embedded SQL client

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/FLINK-8686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16442208#comment-16442208
 ] 

ASF GitHub Bot commented on FLINK-8686:
---------------------------------------

GitHub user twalthr opened a pull request:

    https://github.com/apache/flink/pull/5867

    [FLINK-8686] [sql-client] Improve basic embedded SQL client

    ## What is the purpose of the change
    
    This PR covers the following minor improvements:
    
    - Configure JVM heap size
    - "The input is invalid please check it again." => add allowed range
    - Add more logging instead of swallowing exceptions
    - List properties in error message about missing TS factory sorted by name
    - Add switch to show full stacktraces of exceptions (solved through logging)
    - Minor improvements
    
    
    ## Brief change log
    
    Various changes.
    
    
    ## Verifying this change
    
    Manually verified and existing tests adapted.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): no
      - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
      - The serializers: no
      - The runtime per-record code paths (performance sensitive): no
      - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: no
      - The S3 file system connector: no
    
    ## Documentation
    
      - Does this pull request introduce a new feature? yes
      - If yes, how is the feature documented? JavaDocs


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/twalthr/flink FLINK-8686

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5867.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5867
    
----
commit 39064a5c6b94438d495e93663c00ec6d1b057672
Author: Timo Walther <twalthr@...>
Date:   2018-04-16T11:40:53Z

    [FLINK-8686] [sql-client] Fix invalid cached session properties

commit dbc8bead807c603f23c2708de33e30b4815cb3bd
Author: Timo Walther <twalthr@...>
Date:   2018-04-16T12:02:18Z

    [FLINK-8686] [sql-client] Sort given table source properties

commit 224b34167eb2e8c093acf823abdd8fdaa5bb295b
Author: Timo Walther <twalthr@...>
Date:   2018-04-16T15:25:12Z

    [FLINK-8686] [sql-client] Add logging for exceptions and cluster 
communication

commit d575f2c01283bd18de352bdc62c9c7d3ba5f075a
Author: Timo Walther <twalthr@...>
Date:   2018-04-16T15:33:00Z

    [FLINK-8686] [sql-client] Add valid page range

commit f3205c935937330241e4157905ba6c6d4b9166f4
Author: Timo Walther <twalthr@...>
Date:   2018-04-16T16:02:47Z

    [FLINK-8686] [sql-client] Fix highlighting during result refresh

commit a195924ed748d25641fc4c7073adbf3f4a42f0c8
Author: Timo Walther <twalthr@...>
Date:   2018-04-17T16:25:35Z

    [FLINK-8686] [sql-client] Make JVM heap size configurable

----


> Improve basic embedded SQL client 
> ----------------------------------
>
>                 Key: FLINK-8686
>                 URL: https://issues.apache.org/jira/browse/FLINK-8686
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API &amp; SQL
>            Reporter: Timo Walther
>            Assignee: Timo Walther
>            Priority: Major
>             Fix For: 1.5.0
>
>
> This issue describes follow-up issues that should be fixes in order to make 
> the SQL client more stable:
>  - Add more tests for executor
>  - Configure JVM heap size
>  - Limit changelog and table buffers
>  - "The input is invalid please check it again." => add allowed range
>  - Load dependencies recursively
>  - Clean up results in result store
>  - Improve error message for unsupported batch queries
>  - Add more logging instead swallowing exceptions
>  - List properties in error message about missing TS factory sorted by name
>  - Add command to show loaded TS factories and their required propeties
>  - Add command to reload configuration from files (no need to restart client)
>  - Improve error message in case of invalid json-schema (right now: 
> {{java.lang.IllegalArgumentException: No type could be found in node:<root>}}
>  - Add switch to show full stacktraces of exceptions
>  - Give error message when setting unknown parameters 
> {{result-mode=changelog}} does not give an error but should be 
> {{execution.result-mode=changelog}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)