[
https://issues.apache.org/jira/browse/FLINK-8686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16449957#comment-16449957
]
ASF GitHub Bot commented on FLINK-8686:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5867#discussion_r183721315
--- Diff: flink-libraries/flink-sql-client/bin/sql-client.sh ---
@@ -44,20 +44,32 @@ bin=`dirname "$target"`
. "$bin"/config.sh
if [ "$FLINK_IDENT_STRING" = "" ]; then
- FLINK_IDENT_STRING="$USER"
+ FLINK_IDENT_STRING="$USER"
fi
CC_CLASSPATH=`constructFlinkClassPath`
+export FLINK_ROOT_DIR
+export FLINK_CONF_DIR
+
################################################################################
-# SQL client specific logic
+# SQL Client CLI specific logic
################################################################################
-log=$FLINK_LOG_DIR/flink-$FLINK_IDENT_STRING-sql-client-$HOSTNAME.log
+log=$FLINK_LOG_DIR/flink-$FLINK_IDENT_STRING-sql-client-cli-$HOSTNAME.log
log_setting=(-Dlog.file="$log"
-Dlog4j.configuration=file:"$FLINK_CONF_DIR"/log4j-cli.properties
-Dlogback.configurationFile=file:"$FLINK_CONF_DIR"/logback.xml)
-export FLINK_ROOT_DIR
-export FLINK_CONF_DIR
+if [[ ! ${FLINK_SCC_HEAP} =~ ${IS_NUMBER} ]] || [[ "${FLINK_SCC_HEAP}" -lt
"0" ]]; then
+ echo "[ERROR] Configured SQL Client CLI JVM heap size is not a number.
Please set '${KEY_SCC_MEM_SIZE}' in ${FLINK_CONF_FILE}."
+ exit 1
+fi
+
+if [ "${FLINK_SCC_HEAP}" -gt "0" ]; then
+ export JVM_ARGS="$JVM_ARGS -Xms"$FLINK_SCC_HEAP"m
-Xmx"$FLINK_SCC_HEAP"m"
--- End diff --
Yes, I think that's a valid concern.
Reusing the variable here, might render it unusable to define common
options for TMs and JMs.
> Improve basic embedded SQL client
> ----------------------------------
>
> Key: FLINK-8686
> URL: https://issues.apache.org/jira/browse/FLINK-8686
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Reporter: Timo Walther
> Assignee: Timo Walther
> Priority: Major
> Fix For: 1.5.0
>
>
> This issue describes follow-up issues that should be fixes in order to make
> the SQL client more stable:
> - Add more tests for executor
> - Configure JVM heap size
> - Limit changelog and table buffers
> - "The input is invalid please check it again." => add allowed range
> - Load dependencies recursively
> - Clean up results in result store
> - Improve error message for unsupported batch queries
> - Add more logging instead swallowing exceptions
> - List properties in error message about missing TS factory sorted by name
> - Add command to show loaded TS factories and their required propeties
> - Add command to reload configuration from files (no need to restart client)
> - Improve error message in case of invalid json-schema (right now:
> {{java.lang.IllegalArgumentException: No type could be found in node:<root>}}
> - Add switch to show full stacktraces of exceptions
> - Give error message when setting unknown parameters
> {{result-mode=changelog}} does not give an error but should be
> {{execution.result-mode=changelog}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
