[
https://issues.apache.org/jira/browse/FLINK-8686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16443628#comment-16443628
]
ASF GitHub Bot commented on FLINK-8686:
---------------------------------------
Github user suez1224 commented on the issue:
https://github.com/apache/flink/pull/5867
Hi @twalthr ,
IMO, it's better to seperate the configuration of SQL client from the
configuration of the Flink job. From the user's perspective, many of them
probably do not need to know or use SQL client, putting a SQL client section in
flink-conf.yaml will just confuse the users because they might think that's
part of their flink job configuration.
I suggest, as you already mentioned, we can either 1) add some variable in
the sql-client.sh to allow the advanced users to modify the JVM ARGS within the
script or 2) add a sql-client-conf.yaml to allow advanced user to edit it.
Assuming that it is uncommon to modify the JVM options of the sql client, I
think both options are fine, but I slightly prefer option 2 since sql-client.sh
is not supposed to modified by the users.
> Improve basic embedded SQL client
> ----------------------------------
>
> Key: FLINK-8686
> URL: https://issues.apache.org/jira/browse/FLINK-8686
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Reporter: Timo Walther
> Assignee: Timo Walther
> Priority: Major
> Fix For: 1.5.0
>
>
> This issue describes follow-up issues that should be fixes in order to make
> the SQL client more stable:
> - Add more tests for executor
> - Configure JVM heap size
> - Limit changelog and table buffers
> - "The input is invalid please check it again." => add allowed range
> - Load dependencies recursively
> - Clean up results in result store
> - Improve error message for unsupported batch queries
> - Add more logging instead swallowing exceptions
> - List properties in error message about missing TS factory sorted by name
> - Add command to show loaded TS factories and their required propeties
> - Add command to reload configuration from files (no need to restart client)
> - Improve error message in case of invalid json-schema (right now:
> {{java.lang.IllegalArgumentException: No type could be found in node:<root>}}
> - Add switch to show full stacktraces of exceptions
> - Give error message when setting unknown parameters
> {{result-mode=changelog}} does not give an error but should be
> {{execution.result-mode=changelog}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
