[ 
https://issues.apache.org/jira/browse/FLINK-8686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16449959#comment-16449959
 ] 

ASF GitHub Bot commented on FLINK-8686:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5867#discussion_r183743259
  
    --- Diff: flink-dist/src/main/flink-bin/bin/config.sh ---
    @@ -95,6 +95,8 @@ DEFAULT_ENV_LOG_MAX=5                               # 
Maximum number of old log
     DEFAULT_ENV_JAVA_OPTS=""                            # Optional JVM args
     DEFAULT_ENV_JAVA_OPTS_JM=""                         # Optional JVM args 
(JobManager)
     DEFAULT_ENV_JAVA_OPTS_TM=""                         # Optional JVM args 
(TaskManager)
    +DEFAULT_ENV_JAVA_OPTS_SCC=""                        # Optional JVM args 
(SQL Client CLI)
    +DEFAULT_ENV_JAVA_OPTS_SCG=""                        # Optional JVM args 
(SQL Client Gateway)
    --- End diff --
    
    The Gateway parameter is not used yet. I think we can added when we need it


> Improve basic embedded SQL client 
> ----------------------------------
>
>                 Key: FLINK-8686
>                 URL: https://issues.apache.org/jira/browse/FLINK-8686
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>            Reporter: Timo Walther
>            Assignee: Timo Walther
>            Priority: Major
>             Fix For: 1.5.0
>
>
> This issue describes follow-up issues that should be fixes in order to make 
> the SQL client more stable:
>  - Add more tests for executor
>  - Configure JVM heap size
>  - Limit changelog and table buffers
>  - "The input is invalid please check it again." => add allowed range
>  - Load dependencies recursively
>  - Clean up results in result store
>  - Improve error message for unsupported batch queries
>  - Add more logging instead swallowing exceptions
>  - List properties in error message about missing TS factory sorted by name
>  - Add command to show loaded TS factories and their required propeties
>  - Add command to reload configuration from files (no need to restart client)
>  - Improve error message in case of invalid json-schema (right now: 
> {{java.lang.IllegalArgumentException: No type could be found in node:<root>}}
>  - Add switch to show full stacktraces of exceptions
>  - Give error message when setting unknown parameters 
> {{result-mode=changelog}} does not give an error but should be 
> {{execution.result-mode=changelog}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to