[
https://issues.apache.org/jira/browse/FLINK-8686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452449#comment-16452449
]
ASF GitHub Bot commented on FLINK-8686:
---------------------------------------
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/5867#discussion_r184098778
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/config/Environment.java
---
@@ -91,6 +92,22 @@ public Deployment getDeployment() {
return deployment;
}
+ public String explain() {
+ final StringBuilder sb = new StringBuilder();
+ sb.append("===================== Tables
=====================\n");
+ tables.forEach((name, table) -> {
+ sb.append("- name: ").append(name).append("\n");
+ final DescriptorProperties props = new
DescriptorProperties(true);
+ table.addProperties(props);
--- End diff --
The properties are added to `props` not `table`. Maybe the name is a bit
misleading.
> Improve basic embedded SQL client
> ----------------------------------
>
> Key: FLINK-8686
> URL: https://issues.apache.org/jira/browse/FLINK-8686
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Reporter: Timo Walther
> Assignee: Timo Walther
> Priority: Major
> Fix For: 1.5.0
>
>
> This issue describes follow-up issues that should be fixes in order to make
> the SQL client more stable:
> - Add more tests for executor
> - Configure JVM heap size
> - Limit changelog and table buffers
> - "The input is invalid please check it again." => add allowed range
> - Load dependencies recursively
> - Clean up results in result store
> - Improve error message for unsupported batch queries
> - Add more logging instead swallowing exceptions
> - List properties in error message about missing TS factory sorted by name
> - Add command to show loaded TS factories and their required propeties
> - Add command to reload configuration from files (no need to restart client)
> - Improve error message in case of invalid json-schema (right now:
> {{java.lang.IllegalArgumentException: No type could be found in node:<root>}}
> - Add switch to show full stacktraces of exceptions
> - Give error message when setting unknown parameters
> {{result-mode=changelog}} does not give an error but should be
> {{execution.result-mode=changelog}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
