[GitHub] flink pull request #5448: [FLINK-6469] Configure Memory Sizes with units

[dawidwys]

Github user dawidwys commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5448#discussion_r197711813
  
    --- Diff: 
flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java ---
    @@ -161,7 +162,7 @@ public YarnResourceManager(
                numPendingContainerRequests = 0;
     
                this.webInterfaceUrl = webInterfaceUrl;
    -           this.defaultTaskManagerMemoryMB = 
flinkConfig.getInteger(TaskManagerOptions.TASK_MANAGER_HEAP_MEMORY);
    +           this.defaultTaskManagerMemoryMB = (int) 
MemorySize.parse(flinkConfig.getString(TaskManagerOptions.TASK_MANAGER_HEAP_MEMORY)).getMebiBytes();
    --- End diff --
    
    unnecessary cast


---