[GitHub] flink pull request #5448: [FLINK-6469] Configure Memory Sizes with units

[dawidwys]

Github user dawidwys commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5448#discussion_r197711430
  
    --- Diff: 
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/io/benchmark/StreamNetworkBenchmarkEnvironment.java
 ---
    @@ -66,7 +67,7 @@
      */
     public class StreamNetworkBenchmarkEnvironment<T extends 
IOReadableWritable> {
     
    -   private static final int BUFFER_SIZE = 
TaskManagerOptions.MEMORY_SEGMENT_SIZE.defaultValue();
    +   private static final int BUFFER_SIZE = (int) 
MemorySize.parse(TaskManagerOptions.MEMORY_SEGMENT_SIZE.defaultValue()).getBytes();
    --- End diff --
    
    use `checkedDownCast`


---