[GitHub] flink pull request #5448: [FLINK-6469] Configure Memory Sizes with units

[dawidwys]

Github user dawidwys commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5448#discussion_r197707411
  
    --- Diff: 
flink-core/src/main/java/org/apache/flink/configuration/MemorySize.java ---
    @@ -95,8 +95,8 @@ public long getKibiBytes() {
        /**
         * Gets the memory size in Mebibytes (= 1024 Kibibytes).
         */
    -   public long getMebiBytes() {
    -           return bytes >> 20;
    +   public int getMebiBytes() {
    +           return (int) (bytes >> 20);
    --- End diff --
    
    use `checkedDownCast` here


---