[GitHub] flink pull request #5448: [FLINK-6469] Configure Memory Sizes with units

[dawidwys]

Github user dawidwys commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5448#discussion_r197708797
  
    --- Diff: 
flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/NetworkBufferCalculationTest.java
 ---
    @@ -86,7 +87,7 @@ private static TaskManagerServicesConfiguration 
getTmConfig(
                        networkBufFraction,
                        networkBufMin,
                        networkBufMax,
    -                   TaskManagerOptions.MEMORY_SEGMENT_SIZE.defaultValue(),
    +                   (int) 
MemorySize.parse(TaskManagerOptions.MEMORY_SEGMENT_SIZE.defaultValue()).getBytes(),
    --- End diff --
    
    use `checkedDownCast`


---