Github user GJL commented on a diff in the pull request:
    --- Diff: 
flink-yarn/src/main/java/org/apache/flink/yarn/cli/ ---
    @@ -386,10 +386,10 @@ private ClusterSpecification 
createClusterSpecification(Configuration configurat
                // JobManager Memory
    -           final int jobManagerMemoryMB = 
    +           final int jobManagerMemoryMB = 
    --- End diff --
    Was there a reason against making `JOB_MANAGER_HEAP_MEMORY_MB` a deprecated 
key for `JOB_MANAGER_HEAP_MEMORY` when you worked on FLINK-6469? That is:
    public static final ConfigOption<String> JOB_MANAGER_HEAP_MEMORY =
    I am not sure what happens if someone only configures `jobmanager.heap.mb` 
in `flink-conf.yaml`. Will the value be respected for all deployment modes?
    Same holds for the TaskManager config key.


Reply via email to