Github user GJL commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6297#discussion_r201980407
  
    --- Diff: 
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
    @@ -386,10 +386,10 @@ private ClusterSpecification 
createClusterSpecification(Configuration configurat
                }
     
                // JobManager Memory
    -           final int jobManagerMemoryMB = 
MemorySize.parse(configuration.getString(JobManagerOptions.JOB_MANAGER_HEAP_MEMORY)).getMebiBytes();
    +           final int jobManagerMemoryMB = 
MemorySize.parse(configuration.getString(JobManagerOptions.JOB_MANAGER_HEAP_MEMORY),
 MemorySize.MemoryUnit.MEGA_BYTES).getMebiBytes();
    --- End diff --
    
    Was there a reason against making `JOB_MANAGER_HEAP_MEMORY_MB` a deprecated 
key for `JOB_MANAGER_HEAP_MEMORY` when you worked on FLINK-6469? That is:
    ```
    public static final ConfigOption<String> JOB_MANAGER_HEAP_MEMORY =
                key("jobmanager.heap.size")
                        .defaultValue("1024m")
                        .withDeprecatedKeys("jobmanager.heap.mb")
                    ...
    ```
    I am not sure what happens if someone only configures `jobmanager.heap.mb` 
in `flink-conf.yaml`. Will the value be respected for all deployment modes?
    
    Same holds for the TaskManager config key.


---

Reply via email to