Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/6297#discussion_r202023148
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -386,10 +386,10 @@ private ClusterSpecification
createClusterSpecification(Configuration configurat
}
// JobManager Memory
- final int jobManagerMemoryMB =
MemorySize.parse(configuration.getString(JobManagerOptions.JOB_MANAGER_HEAP_MEMORY)).getMebiBytes();
+ final int jobManagerMemoryMB =
MemorySize.parse(configuration.getString(JobManagerOptions.JOB_MANAGER_HEAP_MEMORY),
MemorySize.MemoryUnit.MEGA_BYTES).getMebiBytes();
--- End diff --
Agreed, missed it previously. Unfortunately `withDeprecatedKeys` won't
solve it though. Either we should revert the option (and use the mb versions),
or anywhere we use the new option, we should also check for the old one.
---
