Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6297#discussion_r202020619
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -386,10 +386,10 @@ private ClusterSpecification
createClusterSpecification(Configuration configurat
}
// JobManager Memory
- final int jobManagerMemoryMB =
MemorySize.parse(configuration.getString(JobManagerOptions.JOB_MANAGER_HEAP_MEMORY)).getMebiBytes();
+ final int jobManagerMemoryMB =
MemorySize.parse(configuration.getString(JobManagerOptions.JOB_MANAGER_HEAP_MEMORY),
MemorySize.MemoryUnit.MEGA_BYTES).getMebiBytes();
--- End diff --
@dawidwys As I understand, backwards compatibility should be prioritized.
See https://github.com/apache/flink/pull/5448#issuecomment-394296226
> We need to add an additional MemoryUnit.parse() method that takes the
"default" unit, so that we parse the old heap sizes such that they are in MB if
nothing else is specified.
---
