zentol commented on a change in pull request #7927: [FLINK-11603][metrics] Port
the MetricQueryService to the new RpcEndpoint
URL: https://github.com/apache/flink/pull/7927#discussion_r269518481
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/akka/AkkaRpcServiceUtils.java
##########
@@ -81,30 +102,46 @@ public static RpcService createRpcService(
String hostname,
String portRangeDefinition,
Configuration configuration) throws Exception {
- final ActorSystem actorSystem =
BootstrapTools.startActorSystem(configuration, hostname, portRangeDefinition,
LOG);
- return createRpcService(configuration, actorSystem);
+ return createRpcService(
+ hostname,
+ portRangeDefinition,
+ configuration,
+ AkkaUtils.getFlinkActorSystemName(),
Review comment:
Right here we're defining a default logic that is a duplicate of
`BootstrapTools.startActorSystem`. Only one method should do this kind of thing.
Basically, just add a new method that calls
`BootstrapTools.startActorSystem` without changing other methods.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
