dawidwys commented on a change in pull request #8057: [FLINK-12028][table] Add
`addColumns`,`renameColumns`, `dropColumns` …
URL: https://github.com/apache/flink/pull/8057#discussion_r270328732
##########
File path:
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/api/batch/table/stringexpr/CalcStringExpressionTest.scala
##########
@@ -362,4 +362,42 @@ class CalcStringExpressionTest extends TableTestBase {
verifyTableEquals(t1, t2)
}
+
+ @Test
+ def testAddColumns(): Unit = {
+ val util = batchTestUtil()
+ val t = util.addTable[(Int, Long, String)]("Table3",'a, 'b, 'c)
+
+ var t1 = t.addColumns(true, concat('c, "Sunny") as 'kid).addColumns('b + 1)
Review comment:
Can we have the same tests for both `string` and `expression` approach? Best
if we could unify them. Maybe sth similar to:
`org.apache.flink.table.expressions.utils.ExpressionTestBase#testAllApis`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
