dawidwys commented on a change in pull request #8057: [FLINK-12028][table] Add
`addColumns`,`renameColumns`, `dropColumns` …
URL: https://github.com/apache/flink/pull/8057#discussion_r270325814
##########
File path:
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/api/tableImpl.scala
##########
@@ -414,6 +413,51 @@ class TableImpl(
new OverWindowedTableImpl(this, overWindows)
}
+ override def addColumns(fields: String): Table = {
+ addColumns(ExpressionParser.parseExpressionList(fields): _*);
+ }
+
+ override def addColumns(fields: Expression*): Table = {
+ addColumns(false, fields: _*)
+ }
+
+ override def addColumns(replaceIfExist: Boolean, fields: String): Table = {
+ addColumns(replaceIfExist, ExpressionParser.parseExpressionList(fields):
_*)
+ }
+
+ override def addColumns(replaceIfExist: Boolean, fields: Expression*): Table
= {
+ val expressionsWithResolvedCalls =
fields.map(_.accept(callResolver)).asJava
+ val extracted = extractAggregationsAndProperties(
+ expressionsWithResolvedCalls,
+ getUniqueAttributeSupplier)
+
+ val aggNames = extracted.getAggregations
+
+ if(aggNames.nonEmpty){
+ throw new TableException(
+ s"The added field expression cannot be an aggregation, find
[${aggNames.head}].")
Review comment:
```suggestion
s"The added field expression cannot be an aggregation, found
[${aggNames.head}].")
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
