dawidwys commented on a change in pull request #8057: [FLINK-12028][table] Add
`addColumns`,`renameColumns`, `dropColumns` …
URL: https://github.com/apache/flink/pull/8057#discussion_r270331130
##########
File path:
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/api/stream/table/CalcTest.scala
##########
@@ -138,6 +138,57 @@ class CalcTest extends TableTestBase {
util.verifyTable(resultTable, expected)
}
+
+ @Test
+ def testAddColumns(): Unit = {
Review comment:
What is the difference between all those cases? Can we parametrize them with
`(isBatch, String/Expression)`. We should think of unifying it. It does not
make sense to copy it to all places.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
