dawidwys commented on a change in pull request #8057: [FLINK-12028][table] Add
`addColumns`,`renameColumns`, `dropColumns` …
URL: https://github.com/apache/flink/pull/8057#discussion_r270327784
##########
File path:
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/api/batch/table/CalcTest.scala
##########
@@ -330,6 +330,57 @@ class CalcTest extends TableTestBase {
util.verifyTable(resultTable, expected)
}
+
+ @Test
+ def testAddColumns(): Unit = {
+ val util = batchTestUtil()
+ val sourceTable = util.addTable[(Int, Long, String)]("MyTable", 'a, 'b, 'c)
+ val resultTable = sourceTable
+ .addColumns("concat(c, 'sunny') as kid")
Review comment:
Could we split that complex test into multiple tests that describe what is
tested? Those tests do not spawn cluster, so they are cheap, we can have them
as many as we like.
What I mean by splitting is having tests like `testSimpleAdd`,
`testReplaceIfExist` etc. Right now it costs the reader a lot of effort to
understand what is being checked.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
