dawidwys commented on a change in pull request #8087: [FLINK-12029][table] Add
column operations for TableApi
URL: https://github.com/apache/flink/pull/8087#discussion_r274352243
##########
File path:
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/expressions/PlannerExpressionConverter.scala
##########
@@ -94,6 +94,12 @@ class PlannerExpressionConverter private extends
ApiExpressionVisitor[PlannerExp
case AS =>
assert(args.size >= 2)
+ args.drop(1).foreach {
Review comment:
Why do we validate it here? The whole `PlannerExpressionConverter` is
already past validationPhase.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
