dawidwys commented on a change in pull request #8087: [FLINK-12029][table] Add
column operations for TableApi
URL: https://github.com/apache/flink/pull/8087#discussion_r274351308
##########
File path:
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/api/tableImpl.scala
##########
@@ -477,6 +484,18 @@ class TableImpl(
private def wrap(operation: TableOperation): Table = {
new TableImpl(tableEnv, operation)
}
+
+ private[flink] def getOutputFieldReferences:
Seq[UnresolvedFieldReferenceExpression] = {
+ operationTree.asInstanceOf[LogicalNode]
+ .output.map(a => new UnresolvedFieldReferenceExpression(a.name))
+ }
+
+ private[flink] def resolveCalls(fields: Seq[Expression]): Seq[Expression] = {
+ val outputFieldReferences = operationTree.asInstanceOf[LogicalNode]
+ .output.map(a => new UnresolvedFieldReferenceExpression(a.name))
+ val expander = new ColumnsOperationExpander(outputFieldReferences)
Review comment:
Why do we need to expands columns here? It seems unnecessary for me. The
only reason for the `resolveCalls` in `tableImpl` is because we need to split
expressions into `projections`, `aggregates` and `windowProperties`. We don't
need to expand columns for that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
