dawidwys commented on a change in pull request #8087: [FLINK-12029][table] Add
column operations for TableApi
URL: https://github.com/apache/flink/pull/8087#discussion_r274784319
##########
File path:
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/api/tableImpl.scala
##########
@@ -564,26 +575,47 @@ class WindowGroupedTableImpl(
fields)
}
+ private def expandColumnsInGroupWindow(window: GroupWindow): GroupWindow = {
Review comment:
I think we should rather modify the `extractFieldReference` to extract also
column expressions (They are actually field references). That way we will have
a more unified approach and we can use the rule to expand them only in the
`ExpressionResolver`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
