hequn8128 commented on a change in pull request #8359: [FLINK-11051][table] Add
streaming window FlatAggregate to Table API
URL: https://github.com/apache/flink/pull/8359#discussion_r282871071
##########
File path:
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/plan/TableOperationConverter.java
##########
@@ -174,7 +177,7 @@ public RelNode
visitWindowAggregate(WindowAggregateTableOperation windowAggregat
.collect(toList());
GroupKey groupKey = relBuilder.groupKey(groupings);
LogicalWindow logicalWindow =
toLogicalWindow(windowAggregate.getGroupWindow());
- return flinkRelBuilder.aggregate(logicalWindow,
groupKey, windowProperties, aggregations).build();
+ return flinkRelBuilder.aggregate(logicalWindow,
groupKey, windowProperties, aggregations, isTableAggregate).build();
Review comment:
Good idea! I think it would be nice if we can make these names consistent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
