hequn8128 commented on a change in pull request #8359: [FLINK-11051][table] Add
streaming window FlatAggregate to Table API
URL: https://github.com/apache/flink/pull/8359#discussion_r282880481
##########
File path:
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/calcite/FlinkRelBuilder.scala
##########
@@ -64,11 +64,15 @@ class FlinkRelBuilder(
override def getTypeFactory: FlinkTypeFactory =
super.getTypeFactory.asInstanceOf[FlinkTypeFactory]
+ /**
+ * Build window aggregate for either aggregate or table aggregate.
+ */
def aggregate(
window: LogicalWindow,
groupKey: GroupKey,
windowProperties: JList[PlannerExpression],
- aggCalls: Iterable[AggCall])
+ aggCalls: Iterable[AggCall],
Review comment:
I think you make a good point here. I will make them consistent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
