hequn8128 commented on a change in pull request #8359: [FLINK-11051][table] Add streaming window FlatAggregate to Table API URL: https://github.com/apache/flink/pull/8359#discussion_r283750256
########## File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala ########## @@ -127,6 +131,9 @@ class AggregationCodeGenerator( val constantTypes = constantExprs.map(_.resultType) val constantFields = constantExprs.map(addReusableBoxedConstant) + val isTableAggregate = aggregates.length == 1 && + aggregates(0).isInstanceOf[TableAggregateFunction[_, _]] Review comment: Make sense, I think we don't need to check the size after validation. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
