hequn8128 commented on a change in pull request #8359: [FLINK-11051][table] Add
streaming window FlatAggregate to Table API
URL: https://github.com/apache/flink/pull/8359#discussion_r283699591
##########
File path:
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/plan/rules/logical/ExtendedAggregateExtractProjectRule.java
##########
@@ -195,8 +206,7 @@ private RelNode getNewAggregate(Aggregate oldAggregate,
RelBuilder relBuilder, M
}
}
- private int getWindowTimeFieldIndex(LogicalWindowAggregate aggregate,
RelNode input) {
- LogicalWindow logicalWindow = aggregate.getWindow();
+ private int getWindowTimeFieldIndex(LogicalWindow logicalWindow,
RelNode input) {
Review comment:
Only do some minor refactor.
`LogicalWindowTableAggregate.getCorrespondingAggregate` returns a
`LogicalWindowAggregate` and the time field will be processed same like
`LogicalWindowAggregate`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
