tillrohrmann commented on a change in pull request #8539: [FLINK-12617]
[container] StandaloneJobClusterEntrypoint defaults to random JobID for non-HA
setups
URL: https://github.com/apache/flink/pull/8539#discussion_r290224245
##########
File path:
flink-container/src/main/java/org/apache/flink/container/entrypoint/StandaloneJobClusterConfiguration.java
##########
@@ -38,10 +39,9 @@
private final SavepointRestoreSettings savepointRestoreSettings;
@Nonnull
- private final JobID jobId;
+ private final Optional<JobID> jobId;
Review comment:
I would be slightly in favour of making this field `Nullable` and using
`Optional.ofNullable()`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
