tillrohrmann commented on a change in pull request #8539: [FLINK-12617]
[container] StandaloneJobClusterEntrypoint defaults to random JobID for non-HA
setups
URL: https://github.com/apache/flink/pull/8539#discussion_r290223715
##########
File path:
flink-container/src/main/java/org/apache/flink/container/entrypoint/ClassPathJobGraphRetriever.java
##########
@@ -121,8 +120,8 @@ private PackagedProgram createPackagedProgram() throws
FlinkException {
}
private String getJobClassNameOrScanClassPath() throws FlinkException {
- if (jobClassName != null) {
- return jobClassName;
+ if (jobClassName.isPresent()) {
Review comment:
In this case, the `Optional` type does not add too much value over
`@Nullable`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
