tillrohrmann commented on a change in pull request #8539: [FLINK-12617]
[container] StandaloneJobClusterEntrypoint defaults to random JobID for non-HA
setups
URL: https://github.com/apache/flink/pull/8539#discussion_r288194803
##########
File path:
flink-container/src/main/java/org/apache/flink/container/entrypoint/StandaloneJobClusterConfigurationParserFactory.java
##########
@@ -105,10 +109,14 @@ private int getRestPort(CommandLine commandLine) throws
FlinkParseException {
}
}
- private static JobID getJobId(CommandLine commandLine) throws
FlinkParseException {
+ private static JobID getJobId(CommandLine commandLine, Configuration
configuration) throws FlinkParseException {
String jobId =
commandLine.getOptionValue(JOB_ID_OPTION.getOpt());
if (jobId == null) {
- return DEFAULT_JOB_ID;
+ if
(configuration.getString(HighAvailabilityOptions.HA_MODE, null) == null) {
Review comment:
Better to replace with
`!HighAvailabilityMode.isHighAvailabilityModeActivated(configuration)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
