tillrohrmann commented on a change in pull request #8539: [FLINK-12617]
[container] StandaloneJobClusterEntrypoint defaults to random JobID for non-HA
setups
URL: https://github.com/apache/flink/pull/8539#discussion_r288197458
##########
File path:
flink-container/src/main/java/org/apache/flink/container/entrypoint/StandaloneJobClusterConfigurationParserFactory.java
##########
@@ -82,7 +86,7 @@ public StandaloneJobClusterConfiguration
createResult(@Nonnull CommandLine comma
final int restPort = getRestPort(commandLine);
final String hostname =
commandLine.getOptionValue(HOST_OPTION.getOpt());
final SavepointRestoreSettings savepointRestoreSettings =
CliFrontendParser.createSavepointRestoreSettings(commandLine);
- final JobID jobId = getJobId(commandLine);
+ final JobID jobId = getJobId(commandLine,
getGlobalConfiguration(configDir, dynamicProperties));
Review comment:
I think we should move the decision which `JobID` to use out of the
`StandaloneJobClusterConfigurationParserFactory`. That way we don't have to
load the global configuration here which actually should only happen after the
`StandaloneJobClusterConfiguration` has been parsed giving the configuration
directory. The decision could be moved to `StandaloneJobClusterEntryPoint` by
introducing a `createJobIdForCluster(clusterConfiguration.getOptionalJobId(),
globalConfiguration)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
