zhijiangW commented on a change in pull request #8680: [FLINK-12706] Introduce 
ShuffleService interface and its configuration
URL: https://github.com/apache/flink/pull/8680#discussion_r292323314
 
 

 ##########
 File path: 
flink-core/src/main/java/org/apache/flink/configuration/CoreOptions.java
 ##########
 @@ -306,4 +306,17 @@
        public static ConfigOption<Long> 
fileSystemConnectionLimitStreamInactivityTimeout(String scheme) {
                return ConfigOptions.key("fs." + scheme + 
".limit.stream-timeout").defaultValue(0L);
        }
+
+       // 
------------------------------------------------------------------------
+       //  shuffle service
+       // 
------------------------------------------------------------------------
+
+       /**
+        * The shuffle service implementation class full name.
+        */
+       public static final ConfigOption<String> SHUFFLE_SERVICE = ConfigOptions
 
 Review comment:
   why not put this option into runtime module? Are there any considerations

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to